Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure file size updates due to getattr #1042

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Oct 16, 2024

What does this PR do?

This commit ensures that a Node has advance_time called on it when
the filesystem calls getattr. If this is not done repeat calls to ls,
for instance, will show the file size not changing although a call to
read would.

@blt blt added the no-changelog label Oct 16, 2024 — with Graphite App
@blt blt marked this pull request as ready for review October 16, 2024 23:43
@blt blt requested a review from a team as a code owner October 16, 2024 23:43
@blt blt force-pushed the blt/update_file_timestamps_to_reflect_real_systemtime branch from 0595449 to 0a6e9c0 Compare October 22, 2024 23:50
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch from 8f3227c to 3cfa40a Compare October 22, 2024 23:50
This was referenced Oct 22, 2024
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch 3 times, most recently from 8f3f944 to 854d58d Compare October 24, 2024 00:02
@blt blt force-pushed the blt/update_file_timestamps_to_reflect_real_systemtime branch from 277331e to 32ad44c Compare October 24, 2024 00:10
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch 2 times, most recently from 340087f to 1d0b1f0 Compare October 24, 2024 00:20
@blt blt force-pushed the blt/update_file_timestamps_to_reflect_real_systemtime branch from ac43e43 to b66b30d Compare October 24, 2024 00:25
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch from 1d0b1f0 to 8c02a22 Compare October 24, 2024 00:26
This was referenced Oct 25, 2024
@blt blt force-pushed the blt/update_file_timestamps_to_reflect_real_systemtime branch from b66b30d to ce08cc3 Compare October 28, 2024 14:41
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch from 8c02a22 to 191bcb0 Compare October 28, 2024 14:41
@blt blt force-pushed the blt/update_file_timestamps_to_reflect_real_systemtime branch 2 times, most recently from 71727dc to 79cde02 Compare October 28, 2024 15:47
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch from 191bcb0 to 55b85e2 Compare October 28, 2024 15:47
@blt blt changed the base branch from blt/update_file_timestamps_to_reflect_real_systemtime to graphite-base/1042 October 28, 2024 16:25
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch from 55b85e2 to b5e67d9 Compare October 28, 2024 16:25
@blt blt changed the base branch from graphite-base/1042 to main October 28, 2024 16:26
This commit ensures that a Node has advance_time called on it when
the filesystem calls getattr. If this is not done repeat calls to ls,
for instance, will show the file size not changing although a call to
read would.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/ensure_file_size_updates_due_to_getattr branch from b5e67d9 to 4206504 Compare October 28, 2024 16:26
@blt blt merged commit 34e3967 into main Oct 28, 2024
17 checks passed
Copy link
Collaborator Author

blt commented Oct 28, 2024

Merge activity

  • Oct 28, 1:15 PM EDT: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants