Fix: prevent StaggeredLayout floating point errors

[Poker-sang]

Fixes

closes #571

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• Tested code with current supported SDKs
• New component
  • Documentation has been added
  • Sample in sample app has been added
  • Analyzers are passing for documentation and samples
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (if applicable)
• Header has been added to all new source files
• Contains NO breaking changes

Other information

[michael-hawker]

@Poker-sang thanks for submitting a PR! 🦙❤️ Though, looks like you accidentally submitted a change to the tooling submodule?

[Poker-sang]

@Poker-sang thanks for submitting a PR! 🦙❤️ Though, looks like you accidentally submitted a change to the tooling submodule?

Sorry I didn't notice this before so I just committed all the changes. I didn't realize that submodule changes would be committed to the main repository as well. I'm still not familiar with git's management of submodules.

[michael-hawker]

Quick style pass comment, will checkout and test out soon. Thanks!

[Poker-sang]

@michael-hawker I hadn't meant to use this. But the .editorconfig file instructed me that I should use this

Windows/.editorconfig

Lines 89 to 92 in c756dd5

	dotnet_style_qualification_for_event = true:silent
	dotnet_style_qualification_for_field = true:silent
	dotnet_style_qualification_for_method = true:silent
	dotnet_style_qualification_for_property = true:silent

[Arlodotexe]

@michael-hawker I hadn't meant to use this. But the .editorconfig file instructed me that I should use this

Windows/.editorconfig

Lines 89 to 92 in c756dd5

	dotnet_style_qualification_for_event = true:silent
	dotnet_style_qualification_for_field = true:silent
	dotnet_style_qualification_for_method = true:silent
	dotnet_style_qualification_for_property = true:silent

Adding for context https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0003-ide0009#overview

The intellisense here has been silenced. The value is set to true, but it should be set to false.

[Poker-sang]

Yes. Though it is silenced. It can still affect code snippets/fixer

[AndrewKeepCoding]

I ran the fixed sample and confirmed that the flickering is gone.

Recording.2024-12-06.174845.mp4

[AndrewKeepCoding]

I didn't record a video but I also confirmed that ItemsStrech: None continue to work without flickering.

[michael-hawker]

Approving and merging based on our prior code reviews and discussions, and on behalf of the great validation work done by @AndrewKeepCoding, thanks Andrew! 🦙❤️

[Poker-sang]

The ItemsStrech=None is fixed length, so it wouldn't have flickering. Or we wouldn't be able to see it even if it did. Though thank for your test❤.

[Poker-sang]

I thought this is transient and not caused by this pr

Error Message:
   Assert.AreEqual failed. Expected:<2>. Actual:<1>. Unexpected token count after adding.
  Stack Trace:
     at RichSuggestBoxExperiment.Tests.Test_RichSuggestBox.<>c__DisplayClass2_0.<<Test_RichSuggestBox_DeleteTokens>b__0>d.MoveNext() in C:\a\Windows\Windows\components\RichSuggestBox\tests\Test_RichSuggestBox.cs:line 143
--- End of stack trace from previous location ---
   at CommunityToolkit.WinUI.DispatcherQueueExtensions.<>c__DisplayClass3_0.<<EnqueueAsync>b__1>d.MoveNext() in /_/components/Extensions/src/Dispatcher/DispatcherQueueExtensions.cs:line 180
--- End of stack trace from previous location ---
   at RichSuggestBoxExperiment.Tests.Test_RichSuggestBox.Test_RichSuggestBox_DeleteTokens(String token1, String token2) in C:\a\Windows\Windows\components\RichSuggestBox\tests\Test_RichSuggestBox.cs:line 133
   at Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.ThreadOperations.ExecuteWithAbortSafety(Action action)

[michael-hawker]

Yup, I'll rekick, we have open issues to investigate those, they're super frustrating, but intermittent, and they only seem to happen in our CI, so they've been super hard for us to understand what's happening.