-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: StaggeredLayout division bug #574
Fix: StaggeredLayout division bug #574
Conversation
Not sure what happened with the tooling submodule here either. Wondering if we could add a test for anything around this to help guard future issues? |
f3794f9
to
97a7942
Compare
reverted too. Is there a way to make git not track changes to submodules? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦙❤️ Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just about to approve and merge, but noticed it was slightly different than when I had first looked before the weekend. Thanks for fixing the tooling submodule stuff.
@michael-hawker Ok reverted it. i commit this ( I moved it here |
97a7942
to
dff9131
Compare
🎉 Thanks @Poker-sang for this quick fix! 🦙❤️ And for moving the column fix to the other PR. I'll get this merged once the CI passes, some strange issue I haven't seen before there; so just re-kicking to see if it was just a stray cosmic ray! 🤞 |
Fixes
closes #542
fix microsoft/PowerToys#35139
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information