Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the default namespace for new components #394

Merged
merged 19 commits into from
Mar 10, 2023
Merged

Updated the default namespace for new components #394

merged 19 commits into from
Mar 10, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Mar 9, 2023 •
edited
Loading

This PR

@Arlodotexe Arlodotexe added enhancement Improvement to an existing feature dev loop ➰ For issues that impact the core dev-loop of building experiments labels Mar 9, 2023
@michael-hawker michael-hawker mentioned this pull request Mar 9, 2023
Merged
@michael-hawker
Copy link
Member

We have some references to Toolkit.Labs.All.sln in the readme and gitignore we should clean up too.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Mar 9, 2023 •
edited
Loading

We have some references to Toolkit.Labs.All.sln in the readme and gitignore we should clean up too.

Thanks for pointing that out - we should probably remove Labs from that solution name before the submodule split. It's referenced in a lot of places. Ticket filed here - #399

@Arlodotexe
Copy link
Member Author

Looks like we might be forced to implement CommunityToolkit/Tooling-Windows-Submodule#15 here anyway. Will continue tomorrow.

@michael-hawker
Copy link
Member

@Arlodotexe I mean we can keep that as a separate PR if we want. We just need to remove the global using CommunityToolkit.Labs.WinUI; line from the global file.

And maybe add it as an explicit using elsewhere in files if needed.

@Arlodotexe Arlodotexe mentioned this pull request Mar 10, 2023
Merged
@michael-hawker
Copy link
Member

michael-hawker commented Mar 10, 2023 •
edited
Loading

Hmmm....

 D:\a\Labs-Windows\Labs-Windows\components\Shimmer\tests\ExampleShimmerTestClass.cs(17,31): error CS0246: The type or namespace name 'Shimmer' could not be found (are you missing a using directive or an assembly reference?) [D:\a\Labs-Windows\Labs-Windows\common\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj]

This job succeeded on the latest commit to main, so must be another change here needed to that project? FYI @Arlodotexe

@Arlodotexe Arlodotexe merged commit 3bde759 into main Mar 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/new-default-namespace branch March 10, 2023 23:50
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
@Arlodotexe
Updated the default namespace for new components (CommunityToolkit#394)
5cb5954 
* Updated default root namespace and PackageId

* Doc fix

* Renamed template csproj

* Move PackageId prefix to property in Directory.Build.props

* Moved code / docs to new default namespace

* Use xmlns:controls instead of xmlns:labs

* Use xmlns:controls instead of xmlns:labs

* Fixed xaml styling

* Removed default component namespace from global usings

* Unify default package ID

* Fixed missing using directive

* Fixed missing using directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees
No one assigned
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Labs from the default namespace for new components
2 participants
@Arlodotexe @michael-hawker