Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experiment] Shimmer #391

Merged
merged 10 commits into from
Mar 10, 2023
Merged

[Experiment] Shimmer #391

merged 10 commits into from
Mar 10, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Mar 8, 2023 •
edited by michael-hawker
Loading

Adding the Shimmer control from the Store. See: #381 and #390

Shimmerrr

niels9001 and others added 4 commits March 8, 2023 11:23
@niels9001 @JustinXinLiu
Init Shimmer
c13bff2 
Co-Authored-By: Justin Liu <[email protected]>
@niels9001 @JustinXinLiu
Renaming properties
84708e9 
Co-Authored-By: Justin Liu <[email protected]>
@niels9001 @JustinXinLiu
More renaming
faabf75 
Co-Authored-By: Justin Liu <[email protected]>
@niels9001
Adding issue
cf80a23
@niels9001 niels9001 changed the title Feature/shimmer [Experiment] Shimmer Mar 8, 2023
@niels9001 niels9001 mentioned this pull request Mar 8, 2023
Closed
michael-hawker
michael-hawker requested changes Mar 8, 2023
View reviewed changes
components/Shimmer/src/Shimmer/Shimmer.Properties.cs Outdated Show resolved Hide resolved
components/Shimmer/src/Shimmer/Shimmer.Properties.cs Show resolved Hide resolved
components/Shimmer/src/Shimmer/Shimmer.Properties.cs Outdated Show resolved Hide resolved
components/Shimmer/src/Shimmer/Shimmer.cs Outdated Show resolved Hide resolved
components/Shimmer/src/Shimmer/Shimmer.cs Show resolved Hide resolved
components/Shimmer/src/Shimmer/Shimmer.cs Outdated Show resolved Hide resolved
@michael-hawker michael-hawker linked an issue Mar 8, 2023 that may be closed by this pull request
🧪 [Experiment] Shimmer #390
Open
20 tasks
@michael-hawker michael-hawker added the experiment 🧪 Used to track issues that are experiments (or their linked discussions) label Mar 9, 2023
@niels9001 niels9001 requested a review from michael-hawker March 9, 2023 17:50
michael-hawker
michael-hawker approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we should be all set, I think! 🎉🎉🎉

Arlodotexe
Arlodotexe approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved, let's ship it! 🥳

@Arlodotexe Arlodotexe merged commit 9d43573 into main Mar 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/shimmer branch March 10, 2023 00:49
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
@Arlodotexe
Merge pull request CommunityToolkit#391 from CommunityToolkit/feature…
a2df940 
…/shimmer

[Experiment] Shimmer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@JustinXinLiu JustinXinLiu Awaiting requested review from JustinXinLiu

Assignees
No one assigned
Labels
experiment 🧪 Used to track issues that are experiments (or their linked discussions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧪 [Experiment] Shimmer
3 participants
@niels9001 @Arlodotexe @michael-hawker