-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove package ID from Segmented/Shimmer #400
Conversation
@Arlodotexe need you to explain to me what's going on here and why our build is passing but the new controls aren't getting packed... this is part of the template: Labs-Windows/template/ProjectTemplate/src/CommunityToolkit.Labs.WinUI.ProjectTemplate.csproj Line 4 in 9d43573
But only Segmented an Shimmer have it:
Which if this is the problem (as I think you mentioned)... why is it in the template still? Can we quickly get a PR that fixes the template and all the things in the repo to be consistent? Possible via this PR of @niels9001, as it's got 1/3rd of the things? Can you confirm the expectations here for posterity? Thanks! |
I'd like to understand later too if this causes an error locally in packing why it doesn't show up as an error in packing in the CI? |
These changes are included in #394, which is ready to merge when the CI passes. |
@Arlodotexe #394 is still building and missing the change to the newly merged Shimmer control (we'll need to audit any other open component PRs for this). Going to merge this one first, as we don't know if #394 has a clean build yet. |
No description provided.