Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package ID from Segmented/Shimmer #400

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

niels9001
Copy link
Collaborator

No description provided.

@niels9001 niels9001 changed the title Remove package ID from Segmented control Remove package ID from Segmented/Shimmer Mar 10, 2023
@michael-hawker
Copy link
Member

@Arlodotexe need you to explain to me what's going on here and why our build is passing but the new controls aren't getting packed... this is part of the template:

<PackageId>CommunityToolkit.Labs.$(PackageIdVariant).ProjectTemplate</PackageId>

But only Segmented an Shimmer have it:

<PackageId>CommunityToolkit.Labs.$(PackageIdVariant).Shimmer</PackageId>

Which if this is the problem (as I think you mentioned)... why is it in the template still?

Can we quickly get a PR that fixes the template and all the things in the repo to be consistent? Possible via this PR of @niels9001, as it's got 1/3rd of the things? Can you confirm the expectations here for posterity? Thanks!

@michael-hawker
Copy link
Member

I'd like to understand later too if this causes an error locally in packing why it doesn't show up as an error in packing in the CI?

@Arlodotexe
Copy link
Member

Arlodotexe commented Mar 10, 2023

@Arlodotexe need you to explain to me what's going on here and why our build is passing but the new controls aren't getting packed... this is part of the template:

<PackageId>CommunityToolkit.Labs.$(PackageIdVariant).ProjectTemplate</PackageId>

But only Segmented an Shimmer have it:

<PackageId>CommunityToolkit.Labs.$(PackageIdVariant).Shimmer</PackageId>

Which if this is the problem (as I think you mentioned)... why is it in the template still?

Can we quickly get a PR that fixes the template and all the things in the repo to be consistent? Possible via this PR of @niels9001, as it's got 1/3rd of the things? Can you confirm the expectations here for posterity? Thanks!

These changes are included in #394, which is ready to merge when the CI passes.

@michael-hawker
Copy link
Member

@Arlodotexe #394 is still building and missing the change to the newly merged Shimmer control (we'll need to audit any other open component PRs for this).

Going to merge this one first, as we don't know if #394 has a clean build yet.

@michael-hawker michael-hawker merged commit c9ad7b7 into main Mar 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/SegmentedControl-package-fix branch March 10, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants