Port zosconsole to next

[JillieBeanSim]

Proposed changes

Release Notes

Milestone: n/a port from main

Changelog: n/a

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

Attention: Patch coverage is 67.24138% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (2a3d595) to head (91591c8).
Report is 34 commits behind head on next.

Files with missing lines	Patch %	Lines
...es/zowe-explorer/src/zosconsole/ZosConsolePanel.ts	62.74%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #3058      +/-   ##
==========================================
- Coverage   92.86%   92.73%   -0.13%     
==========================================
  Files         112      113       +1     
  Lines       11509    11566      +57     
  Branches     2560     2424     -136     
==========================================
+ Hits        10688    10726      +38     
- Misses        819      838      +19     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

Thanks for porting this over Billie!

I noticed that the "text field" for displaying the console output is smaller in the port:

The text field in v2 fills the remaining space:

[JillieBeanSim]

Thanks for porting this over Billie!

I noticed that the "text field" for displaying the console output is smaller in the port:

The text field in v2 fills the remaining space:

Hey @traeok this happened when the changes to HTMLTemplate were reverted per @zFernand0 's request. Do we change it back for this to work as it does in v2 or will that change affect other new v3 functionality that may use the HTMLTemplate?

[zFernand0]

Hey traeok this happened when the changes to HTMLTemplate were reverted per zFernand0 's request. Do we change it back for this to work as it does in v2 or will that change affect other new v3 functionality that may use the HTMLTemplate?

Hey @JillieBeanSim,
Sorry for the confusion. If we want to port the same console terminal (with a webview implementation) we will need to merge the two (main and next) HTML Templates without impacting any existing functionality.

I don't mind opening a PR with the integrated terminal implementation before the end of the week. That way we don't have to merge the templates together and then refactor the implementation to use the built-in VSCode capabilities 😋

[zFernand0]

Hey,
I wanted to summarize the discussion that we had during standup today (for transparency)

We are fast approaching the Breaking-change code-freeze date for V3.

We mentioned that it might be a bit late to introduce more enhancements into our version 3.0.0 since the GA date is a little over month away.

We also discussed the potential breaking change (for both, users[UX] and developers[webview]) if we decide to implement integrated terminals after having a webview implementation in V3.

---

Please feel free to expand if I missed anything 😋

[adam-wolfe]

Hey, I wanted to summarize the discussion that we had during standup today (for transparency)

We are fast approaching the Breaking-change code-freeze date for V3.

We mentioned that it might be a bit late to introduce more enhancements into our version 3.0.0 since the GA date is a little over month away.

We also discussed the potential breaking change (for both, users[UX] and developers[webview]) if we decide to implement integrated terminals after having a webview implementation in V3.

Please feel free to expand if I missed anything 😋

This is a good summary, my questions are:

1. If we switch from a WebView (3.0.0) to an integrated terminal (3.1.0), would this actually break something (other than being a change to UX)?
   a. Could we make the WebView implementation 'deprecated' somehow in V3 to avoid having extenders try to do anything with it?
2. Would it be safer to release 3.0.0 without the z/OS console at all (and then introduce the integrated terminal in 3.1.0)?

If I had to choose a way forward, I would stick with the WebView implementation for v3.0.0, then target the integrated MVS+TSO+SSH terminal work for V3.1.0 (code freeze on Jan 02, 2025).

[JillieBeanSim]

do we want to mark it deprecated for v3 too moving forward for awareness with plan to move over to the integrated terminal?

[traeok]

This logic is required to support our webviews in v3 - we should add these back to avoid breaking other webviews

[adam-wolfe]

LGTM

[zFernand0]

LGTM! 😋

Note that the console/terminal will not work unless the session/profile is loaded in a tree and has been validated.

[traeok]

I pushed up a change to fix a couple missing items from the HTML template.
Tested and LGTM - thanks again @JillieBeanSim for the port and for addressing feedback

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud