Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute z/OS console panel #2925

Merged
merged 32 commits into from
Aug 20, 2024
Merged

Conversation

crshnburn
Copy link
Contributor

Proposed changes

Adds a new view into the panels area which allows a user to send operator commands to the selected z/OS Region and see the responses in a terminal type environment rather than having to use the Issue MVS Command option from the side panel each time.

Release Notes

Milestone:

Changelog: Add z/OS Console Panel

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.34%. Comparing base (f5eb0a1) to head (e50a578).
Report is 8 commits behind head on main.

Files Patch % Lines
...es/zowe-explorer/src/zosconsole/ZosConsolePanel.ts 65.38% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
+ Coverage   93.32%   93.34%   +0.01%     
==========================================
  Files         105      105              
  Lines       11043    11043              
  Branches     2317     2420     +103     
==========================================
+ Hits        10306    10308       +2     
+ Misses        736      734       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crshnburn this is really cool, I do see some polish items needing done and would love a demo for the squad if possible. We have our scrums Tues & Thurs each week starting at 11 am ET, the invite is available on the Zowe Calendar

I do notice that only the zosmf profiles show as available profiles for the action in the z/OS Console view, we would want all profiles to show if the type is registered with the trees as seen in screenshot for pallet command for issuing MVS commands that already exists in ZE. I also wonder if we could play with the sizing, I see it making the user scroll in smaller window than the view. Also, please address any failing check regarding changelogs, unit test coverage, etc. Thanks!

Screenshot 2024-05-30 at 1 55 42 PM Screenshot 2024-05-30 at 1 56 07 PM Screenshot 2024-05-30 at 3 00 14 PM

@adam-wolfe
Copy link
Contributor

@crshnburn, this is great. I agree with @JillieBeanSim's suggestions and would add two more, if possible:

  • Scroll to the end of the output automatically
  • Use a fixed-width font

@t1m0thyj t1m0thyj added this to the v2.17.0 milestone Jun 4, 2024
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
15.5% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Signed-off-by: Andrew Smithson <[email protected]>
@adam-wolfe
Copy link
Contributor

Tried a new build and the changes look good in terms of automatically adjusting the terminal size, scrolling to the bottom of command output, and the monospace font.

@JillieBeanSim
Copy link
Contributor

I really like the updates @crshnburn, I do still see some things on top of failing checks but can try to help address. My first try, I didn't realize I didn't have credentials tied to the profile and got an error vs the prompt so had to do filter search using profile in ZE to get prompted then went back to console and did a command that was successful but format didn't start new line with new command.
Screenshot 2024-06-19 at 2 29 01 PM

@JillieBeanSim JillieBeanSim requested review from JillieBeanSim, t1m0thyj and traeok and removed request for JillieBeanSim August 13, 2024 20:37
@JillieBeanSim JillieBeanSim dismissed their stale review August 13, 2024 20:38

addressing comments

Signed-off-by: Billie Simmons <[email protected]>
Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some font suggestions

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks to all involved: @crshnburn @JillieBeanSim @zFernand0 😁

When this PR is bundled as a VSIX, the codicons fail to render in webview because the node_modules folder is missing. To fix this we could bundle the codicon CSS/TTF files with the extension - see 16b7769 in the V3 branch.

Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim
Copy link
Contributor

addressed formatting and font comments, will add what is needed from next branch next.
here is the formatting with the command text and profile picker at top and output below
Screenshot 2024-08-19 at 9 26 18 PM
@t1m0thyj & @adam-wolfe let me know what you think, thanks

Signed-off-by: Billie Simmons <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@zFernand0 zFernand0 mentioned this pull request Aug 20, 2024
19 tasks
@JillieBeanSim
Copy link
Contributor

bug report created for Theia test failures #3053

Signed-off-by: Timothy Johnson <[email protected]>
Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated UI looks good, thanks @JillieBeanSim!

Fixed the codicon path since the node_modules/@vscode/codicons path is at a different location between the main and next branches 😋

Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JillieBeanSim JillieBeanSim merged commit ea0b0b0 into zowe:main Aug 20, 2024
21 of 24 checks passed
@JillieBeanSim
Copy link
Contributor

will create a porting PR for next

@JillieBeanSim
Copy link
Contributor

port PR #3058

@t1m0thyj t1m0thyj removed the needs-ported Apply to issues or PRs that need ported label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants