-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute z/OS console panel #2925
Conversation
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
==========================================
+ Coverage 93.32% 93.34% +0.01%
==========================================
Files 105 105
Lines 11043 11043
Branches 2317 2420 +103
==========================================
+ Hits 10306 10308 +2
+ Misses 736 734 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @crshnburn this is really cool, I do see some polish items needing done and would love a demo for the squad if possible. We have our scrums Tues & Thurs each week starting at 11 am ET, the invite is available on the Zowe Calendar
I do notice that only the zosmf profiles show as available profiles for the action in the z/OS Console view, we would want all profiles to show if the type is registered with the trees as seen in screenshot for pallet command for issuing MVS commands that already exists in ZE. I also wonder if we could play with the sizing, I see it making the user scroll in smaller window than the view. Also, please address any failing check regarding changelogs, unit test coverage, etc. Thanks!
@crshnburn, this is great. I agree with @JillieBeanSim's suggestions and would add two more, if possible:
|
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Signed-off-by: Andrew Smithson <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Signed-off-by: Andrew Smithson <[email protected]>
Tried a new build and the changes look good in terms of automatically adjusting the terminal size, scrolling to the bottom of command output, and the monospace font. |
I really like the updates @crshnburn, I do still see some things on top of failing checks but can try to help address. My first try, I didn't realize I didn't have credentials tied to the profile and got an error vs the prompt so had to do filter search using profile in ZE to get prompted then went back to console and did a command that was successful but format didn't start new line with new command. |
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some font suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks to all involved: @crshnburn @JillieBeanSim @zFernand0 😁
When this PR is bundled as a VSIX, the codicons fail to render in webview because the node_modules
folder is missing. To fix this we could bundle the codicon CSS/TTF files with the extension - see 16b7769 in the V3 branch.
Signed-off-by: Billie Simmons <[email protected]>
addressed formatting and font comments, will add what is needed from next branch next. |
Signed-off-by: Billie Simmons <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Billie Simmons <[email protected]>
bug report created for Theia test failures #3053 |
Signed-off-by: Timothy Johnson <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated UI looks good, thanks @JillieBeanSim!
Fixed the codicon path since the node_modules/@vscode/codicons
path is at a different location between the main
and next
branches 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
will create a porting PR for next |
port PR #3058 |
Proposed changes
Adds a new view into the panels area which allows a user to send operator commands to the selected z/OS Region and see the responses in a terminal type environment rather than having to use the Issue MVS Command option from the side panel each time.
Release Notes
Milestone:
Changelog: Add z/OS Console Panel
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments