Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker to deploy integration #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Docker to deploy integration #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45eff56
Configure Docker
Aug 30, 2024
9e7e919
Improve docker file
Sep 28, 2024
9b799d9
add docker ignore
Sep 28, 2024
6b7737b
Add | docker information deployment in documentation
Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
FROM node:latest AS build

WORKDIR /code

COPY package.json ./

RUN npm install

COPY . .
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Copy statement will copy all files in folder no include in .dockerignore


ENTRYPOINT [ "npm", "run", "start" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to export port 4000 and manually copy the .env file / add a way to expose environment variables to the container, like so:

COPY . .

COPY .env ./

ENTRYPOINT [ "npm", "run", "start" ]

EXPOSE 4000

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add almost a commentaries to better explanation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know If I can improve something else

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
},
{
"name": "EkaanshArora"
},
{
"name": "Jose Sarmiento"
}
],
"license": "ISC",
Expand Down