Add Docker to deploy integration #7
Conversation
There was a problem hiding this comment.
Hey @DanielSarmiento04 we'll need to make a few improvements to this PR before we can merge this (I've left a comment on the dockerfile). We also would need you to document the steps to use the Dockerfile by the end user to make this useful for everyone, thanks for you contribution!
Dockerfile
Outdated
|
|
||
| COPY . . | ||
|
|
||
| ENTRYPOINT [ "npm", "run", "start" ] |
There was a problem hiding this comment.
You'll need to export port 4000 and manually copy the .env file / add a way to expose environment variables to the container, like so:
COPY . .
COPY .env ./
ENTRYPOINT [ "npm", "run", "start" ]
EXPOSE 4000There was a problem hiding this comment.
I add almost a commentaries to better explanation
There was a problem hiding this comment.
Let me know If I can improve something else
| RUN npm install | ||
|
|
||
| # Copy the rest of the source code | ||
| COPY . . |
There was a problem hiding this comment.
Note that Copy statement will copy all files in folder no include in .dockerignore
There was a problem hiding this comment.
I add a step by step to run with docker, let me know is clear the information or if i need to add more information
The follow pull request try to improve the deployment method using docker, to do it I make the default 4000 port as inbound port and use oficial node image from docker hub