-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft add of datasource for user grants #201
Open
dfry
wants to merge
3
commits into
zitadel:main
Choose a base branch
from
mojaloop:feat/add-usergrant-datasource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
package user_grant | ||
|
||
import ( | ||
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | ||
) | ||
|
||
func GetDatasource() *schema.Resource { | ||
return &schema.Resource{ | ||
Description: "represents role grants", | ||
Schema: map[string]*schema.Schema{ | ||
grantIDVar: { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "ID of the usergrant", | ||
}, | ||
UserIDVar: { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "ID of the user", | ||
}, | ||
RoleKeysVar: { | ||
Type: schema.TypeList, | ||
Computed: true, | ||
Description: "A set of all roles for a user.", | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
}, | ||
projectNameVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Name of the project.", | ||
Computed: true, | ||
}, | ||
roleStatusVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Status of role", | ||
Computed: true, | ||
}, | ||
userNameVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "username", | ||
Computed: true, | ||
}, | ||
emailVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "email of user", | ||
Computed: true, | ||
}, | ||
nameVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "display name of user", | ||
Computed: true, | ||
}, | ||
}, | ||
ReadContext: readDS, | ||
} | ||
} | ||
|
||
func ListDatasources() *schema.Resource { | ||
return &schema.Resource{ | ||
Description: "represents role grants", | ||
Schema: map[string]*schema.Schema{ | ||
projectNameVar: { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "Name of the project.", | ||
}, | ||
userGrantDataVar: { | ||
Type: schema.TypeList, | ||
Computed: true, | ||
Description: "A list of all usergrants.", | ||
Elem: &schema.Resource{ | ||
Schema: map[string]*schema.Schema{ | ||
grantIDVar: { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
Description: "grantID", | ||
}, | ||
UserIDVar: { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
Description: "userid", | ||
}, | ||
RoleKeysVar: { | ||
Type: schema.TypeList, | ||
Computed: true, | ||
Description: "A set of all roles for a user.", | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
}, | ||
projectNameVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Name of the project.", | ||
Computed: true, | ||
}, | ||
roleStatusVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Status of role", | ||
Computed: true, | ||
}, | ||
userNameVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "username", | ||
Computed: true, | ||
}, | ||
emailVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "email of user", | ||
Computed: true, | ||
}, | ||
nameVar: { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "display name of user", | ||
Computed: true, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
ReadContext: list, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is only the projectName used as a query? It is even listed as computed, I would rather use other identifiers first, and maybe provide the name later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am using projectName as the query because that is my current use case, i need to lookup the user grants by project name. Feel free to make it more generic or point me to an example of how you want it done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me for the start, normally I would at least add the identifier of the project itself as a base query.
Have a look at the application_saml resouce as an example.