-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft add of datasource for user grants #201
base: main
Are you sure you want to change the base?
Conversation
@stebenz @hifabienne any feedback on this suggested feature? is this something you could see incorporating into your next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions about the content of the PR.
|
||
ProjectNameQuery: &user.UserGrantProjectNameQuery{ | ||
|
||
ProjectName: projectName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is only the projectName used as a query? It is even listed as computed, I would rather use other identifiers first, and maybe provide the name later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am using projectName as the query because that is my current use case, i need to lookup the user grants by project name. Feel free to make it more generic or point me to an example of how you want it done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me for the start, normally I would at least add the identifier of the project itself as a base query.
Have a look at the application_saml resouce as an example.
Please also include the necessary templates and examples to regnerate the documentation, as a reference have a look in the paths templates/resources/application_saml.md.tmpl, templates/resources/application_samls.md.tmpl, examples/provider/data-sources/application_saml.tf and examples/provider/data-sources/application_samls.tf. Testing for the datasource is also missing, please refer for that to the application_oidc/datasource_test.go |
Adding this PR just to find out if this would be an acceptable addition to the provider.
Definition of Ready