Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Journal: Browsing Keywords fails when browser's downcase the URL. #1754

Closed
2 tasks done
Tracked by #5
, #17
...
sentry-io bot opened this issue Aug 13, 2023 · 1 comment
Closed
2 tasks done
Tracked by #5
, #17
...

🐞 Journal: Browsing Keywords fails when browser's downcase the URL. #1754

sentry-io bot opened this issue Aug 13, 2023 · 1 comment
Assignees
@zspencer
Labels
🐞 bug Something isn't working 🔨 Squashed Bugs we think we fixed

Comments

@sentry-io
Copy link

sentry-io bot commented Aug 13, 2023 •
edited by zspencer
Loading

Sentry Issue: CONVENE-1T

Pundit::NotDefinedError: unable to find policy `NilClassPolicy` for `nil` (Pundit::NotDefinedError)
  app/furniture/journal/keywords_controller.rb:8:in `show'
    authorize(keyword)
  app/models/neighborhood/time_zone_mixin.rb:7:in `set_time_zone'
    Time.use_zone(ENV.fetch("NEIGHBORHOOD_TIME_ZONE"), &block)
...
(82 additional frame(s) were not displayed)

Remediations

  • Make a Keyword cannot be found, it 404s
  • Make finding keywords case insensitive
@zspencer zspencer added the 🐞 bug Something isn't working label Aug 14, 2023
@zspencer zspencer self-assigned this Aug 14, 2023
@zspencer
Copy link
Member

This looks like an issue with:

  • Case sensitivity when looking for keywords
  • not 404ing properly when a Keyword cannot be found.

I'll try and fix at least the 404ing, and maybe case sensitivity / by alias.

@zspencer zspencer mentioned this issue Aug 14, 2023
Open
5 tasks
@zspencer zspencer changed the title Journal: Pundit::NotDefinedError: unable to find policy NilClassPolicy for nil (Pundit::NotDefinedError) Journal: Browsing Keywords fails when browser's downcase the URL. Aug 14, 2023
zspencer added a commit that referenced this issue Aug 14, 2023
@zspencer
🐞 Neighborhood: Handle ActiveRecord::RecordNotFound
197970f 
- #1754

It appears we do not ... do the baseline NotFound handling... Oops.
This was referenced Aug 14, 2023
Merged
Merged
zspencer added a commit that referenced this issue Aug 14, 2023
@zspencer
✨ Neighborhood: Handle RecordNotFound exceptions (#1756)
69d278a 
* 🐞 `Neighborhood`: Handle ActiveRecord::RecordNotFound

- #1754

It appears we do not ... do the baseline NotFound handling... Oops.

* Fix failing tests
zspencer added a commit that referenced this issue Aug 14, 2023
@zspencer
🐞🔨 Journal: Fix Keywords#show erroring instead of 404ing (#1755)
b955757 
- #1754

* `Journal`: `Keywords` are case insensitive and aliasable

* `Journal`: `Keyword`s redirect to their canonical location
@zspencer zspencer mentioned this issue Feb 17, 2024
Open
4 tasks
@zspencer zspencer changed the title Journal: Browsing Keywords fails when browser's downcase the URL. 🐞 Journal: Browsing Keywords fails when browser's downcase the URL. Aug 14, 2023
@zspencer zspencer added the 🔨 Squashed Bugs we think we fixed label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zspencer zspencer

Labels
🐞 bug Something isn't working 🔨 Squashed Bugs we think we fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zspencer