🐞🔨 Journal: Fix Keywords#show erroring instead of 404ing (#1755)

- #1754

* `Journal`: `Keywords` are case insensitive and aliasable

* `Journal`: `Keyword`s redirect to their canonical location

app/furniture/journal/keywords_controller.rb

@@ -1,11 +1,17 @@
 class Journal
   class KeywordsController < FurnitureController
     expose(:keyword, scope: -> { policy_scope(journal.keywords) }, model: Keyword,
-      find: ->(id, scope) { scope.find_by(canonical_keyword: id) })
+      find: lambda do |id, scope|
+        scope.search(id)&.first ||
+          (raise ActiveRecord::RecordNotFound.new(nil, self, id, id))
+      end)
 
     expose(:journal, -> { Journal.find(params[:journal_id]) })
     def show
       authorize(keyword)
+      if polymorphic_path(keyword.location) != request.path
+        redirect_to(polymorphic_path(keyword.location))
+      end
     end
   end
 end

spec/furniture/journal/keywords_controller_request_spec.rb

@@ -7,8 +7,36 @@
       response
     end
 
-    let(:keyword) { create(:journal_keyword) }
+    let(:keyword) { create(:journal_keyword, aliases: ["pony"]) }
+    let(:journal) { keyword.journal }
 
     it { is_expected.to be_ok }
+
+    context "when the keyword is of a different case" do
+      subject(:perform_request) do
+        get polymorphic_path(journal.location(child: :keyword), id: keyword.canonical_keyword.upcase)
+        response
+      end
+
+      it { is_expected.to redirect_to polymorphic_path(keyword.location) }
+    end
+
+    context "when the keyword is an alias" do
+      subject(:perform_request) do
+        get polymorphic_path(journal.location(child: :keyword), id: "Pony")
+        response
+      end
+
+      it { is_expected.to redirect_to polymorphic_path(keyword.location) }
+    end
+
+    context "when the keyword doesn't exist" do
+      subject(:perform_request) do
+        get polymorphic_path(journal.location(child: :keyword), id: "Gibberish")
+        response
+      end
+
+      it { is_expected.to be_not_found }
+    end
   end
 end