✨ Neighborhood: Handle RecordNotFound exceptions (#1756)

* 🐞 `Neighborhood`: Handle ActiveRecord::RecordNotFound

- #1754

It appears we do not ... do the baseline NotFound handling... Oops.

* Fix failing tests

app/controllers/application_controller.rb

@@ -6,6 +6,8 @@ class ApplicationController < ActionController::Base
   before_action :enforce_ssl
   before_action :ensure_on_byo_domain
 
+  rescue_from ActiveRecord::RecordNotFound, with: :render_not_found
+
   include Pundit::Authorization
   after_action :verify_authorized, except: [:index] # rubocop:disable Rails/LexicallyScopedActionFilter
   after_action :verify_policy_scoped

spec/furniture/marketplace/orders_controller_request_spec.rb

@@ -48,8 +48,7 @@
     end
 
     context "when the order is not viewable by the current person" do
-      specify { expect { perform_request }.to raise_error(ActiveRecord::RecordNotFound) }
-      # it { is_expected.to be_not_found}
+      it { is_expected.to be_not_found }
     end
   end
 end

spec/requests/memberships_request_spec.rb

@@ -86,7 +86,9 @@
       let(:membership) { create(:membership) }
 
       it "does not delete the membership" do
-        expect { perform_request }.to raise_error(ActiveRecord::RecordNotFound)
+        perform_request
+
+        expect(response).to be_not_found
         expect(membership.reload).to be_present
         expect(membership.reload).not_to be_revoked
       end