Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --run-with-subprocess flag #46

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

haorenfsa
Copy link
Collaborator

@haorenfsa haorenfsa commented Nov 15, 2023

@sre-ci-robot sre-ci-robot requested a review from zwd1208 November 15, 2023 11:24
@sre-ci-robot
Copy link
Collaborator

@haorenfsa: GitHub didn't allow me to request PR reviews from the following users: jaime0815.

Note that only zilliztech members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zwd1208 @jaime0815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb0ef79) 80.02% compared to head (739d431) 80.04%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/controllers/deployment_updater.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   80.02%   80.04%   +0.02%     
==========================================
  Files          47       47              
  Lines        4867     4877      +10     
==========================================
+ Hits         3895     3904       +9     
- Misses        819      820       +1     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa added the lgtm looks good to merge label Nov 16, 2023
@sre-ci-robot sre-ci-robot merged commit e0927aa into zilliztech:main Nov 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants