Skip to content

Commit

Permalink
Support --run-with-subprocess flag
Browse files Browse the repository at this point in the history 
Signed-off-by: shaoyue.chen <[email protected]>
  • Loading branch information
@haorenfsa
haorenfsa committed Nov 15, 2023
1 parent cb0ef79 commit 1492d19
Show file tree
Hide file tree
Showing 11 changed files with 179 additions and 4 deletions.
5 changes: 5 additions & 0 deletions apis/milvus.io/v1beta1/components_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ type ComponentSpec struct {
// +kubebuilder:validation:Optional
Commands []string `json:"commands,omitempty"`

// RunWithSubProcess whether to run milvus with flag --run-with-subprocess
// note: supported in 2.2.15, 2.3.2+
// +kubebuilder:validation:Optional
RunWithSubProcess *bool `json:"runWithSubProcess,omitempty"`

// +kubebuilder:validation:Optional
ImagePullPolicy *corev1.PullPolicy `json:"imagePullPolicy,omitempty"`

Expand Down
6 changes: 6 additions & 0 deletions apis/milvus.io/v1beta1/zz_generated.deepcopy.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 46 additions & 0 deletions charts/milvus-operator/templates/crds.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -1403,6 +1405,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -2016,6 +2020,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -2547,6 +2553,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -3080,6 +3088,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -3650,6 +3660,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -4199,6 +4211,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -4730,6 +4744,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -5280,6 +5296,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -5331,6 +5349,8 @@ spec:
type: array
x-kubernetes-preserve-unknown-fields: true
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -5838,6 +5858,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -7024,6 +7046,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -8108,6 +8132,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -8639,6 +8665,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -9252,6 +9280,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -9783,6 +9813,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -10316,6 +10348,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -10886,6 +10920,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -11435,6 +11471,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -11966,6 +12004,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -12516,6 +12556,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -12567,6 +12609,8 @@ spec:
type: array
x-kubernetes-preserve-unknown-fields: true
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -13074,6 +13118,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down
22 changes: 22 additions & 0 deletions config/crd/bases/milvus.io_milvusclusters.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -1402,6 +1404,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -2015,6 +2019,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -2546,6 +2552,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -3079,6 +3087,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -3649,6 +3659,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -4198,6 +4210,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -4729,6 +4743,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -5279,6 +5295,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -5330,6 +5348,8 @@ spec:
type: array
x-kubernetes-preserve-unknown-fields: true
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down Expand Up @@ -5837,6 +5857,8 @@ spec:
x-kubernetes-int-or-string: true
type: object
type: object
runWithSubProcess:
type: boolean
schedulerName:
type: string
serviceAccountName:
Expand Down
Loading

0 comments on commit 1492d19

Please sign in to comment.