Fix quirk ID test ignoring custom clusters in v2 quirks #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The quirk ID cluster handler test currently also checks that all cluster handlers in the registry have a cluster that ZHA can find somewhere.
Previously, the ZHA test only looped through the v1 quirks registry to get all custom clusters. With this PR, we also go over
adds_metadata
andreplaces_metadata.add
to include the cluster ids of custom clusters used in v2 quirks.all_quirk_ids
was also renamed tocluster_quirk_id_map
, as that name should hopefully be slightly more clear.The renaming is done in a separate commit, so feel free to look at the individual commits for a smaller diff.
Additional information
Unblocks:
This test should likely be separated in the future (Filed: #265).
We also have places in zha-quirks that would need similar logic. Maybe we can unify this for v2 quirks somewhere, so we don't have to access
adds_metadata
andreplaces_metadata.add
directly in all those tests? (Filed: #266)