Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solana balance querying to getBalances #180

Closed
fadeev opened this issue Sep 9, 2024 · 8 comments
Closed

Add Solana balance querying to getBalances #180

fadeev opened this issue Sep 9, 2024 · 8 comments
Assignees

Comments

@fadeev
Copy link
Member

fadeev commented Sep 9, 2024

  • Devnet and mainnet support
  • Update the hardhat balances task as well
  • Make sure the function handles a case when Solana key is not available (skip balance querying)
  • Ensure getBalances still works in browser (Balances component in UniversalKit should show SOL balance)
  • Ensure that address derived in the toolkit matches the one in the official Solana extension wallet for the same key/mnemonic.
  • Add tests
@lukema95
Copy link
Collaborator

lukema95 commented Sep 9, 2024

I would like to try it.

@fadeev
Copy link
Member Author

fadeev commented Sep 11, 2024

If you think any changes to how ZetaChainClient is initialized need to be made, do comment! We can create a separate issue for that.

@lukema95
Copy link
Collaborator

If you think any changes to how ZetaChainClient is initialized need to be made, do comment! We can create a separate issue for that.

Do we need to add a component to universalkit that connects to the Solana wallet?

@fadeev
Copy link
Member Author

fadeev commented Sep 16, 2024

@lukema95 as part of a separate contribution, yes!

zeta-chain/universalkit#22

@fadeev
Copy link
Member Author

fadeev commented Sep 16, 2024

Seems like Solana can be added to RainbowKit:

https://docs.phantom.app/library-integrations/rainbowkit

@lukema95
Copy link
Collaborator

lukema95 commented Sep 17, 2024

Seems like Solana can be added to RainbowKit:

https://docs.phantom.app/library-integrations/rainbowkit

The Phantom wallet also supports EVM, so here RainbowKit only supports Phantom's EVM network, not Solana's. solana currently uses a lot of wallets like Backpack, and should have a tool to connect more Solana wallets.

@lukema95
Copy link
Collaborator

As the number of supported heterogeneous chains increases, perhaps we should build a tool to manage all wallets.

@fadeev
Copy link
Member Author

fadeev commented Sep 19, 2024

Ok, for now getBalances should just probably just take a Solana address optionally like EVM and Bitcoin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants