Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Solana deposit function callable from ZetaChainClient and from browser #182

Closed
3 tasks
fadeev opened this issue Sep 11, 2024 · 2 comments
Closed
3 tasks
Assignees

Comments

@fadeev
Copy link
Member

fadeev commented Sep 11, 2024

Right now the function reads a key from a filesystem. This works in a Hardhat/Node.js environment, but of course doesn't work in a browser.

https://github.com/zeta-chain/toolkit/blob/73b823d9341b2e30e6ece801c8cbe19daaca7e5d/packages/client/src/solanaDeposit.ts

We need to ensure that the function can be used from a browser.

const client = new ZetaChainClient({
  network: "testnet",
  //...
});
client.solanaDeposit()

For EVM chains we're using Ethers signer. For Solana I'm assuming it's going to be something else. Although, RainbowKit integrates with Solana.

Tasks

Preview Give feedback

Related: #180

@lukema95
Copy link
Collaborator

lukema95 commented Nov 5, 2024

@fadeev We haven't used this function in any examples yet, have we?

@fadeev
Copy link
Member Author

fadeev commented Nov 5, 2024

@fadeev We haven't used this function in any examples yet, have we?

Not yet, no, but it can be used with this example https://github.com/zeta-chain/example-contracts/tree/main/omnichain/swap

See #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants