-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SPL token balances #204
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request enhance the Changes
Possibly related issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/client/src/getBalances.ts (1)
360-360
: Simplify conditional check using optional chainingThe condition
if (r.result && r.result.value && r.result.value.length > 0)
can be simplified using optional chaining for better readability.Suggested code change:
- if (r.result && r.result.value && r.result.value.length > 0) { + if (r.result?.value?.length > 0) {🧰 Tools
🪛 Biome (1.9.4)
[error] 360-360: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/client/src/getBalances.ts
(2 hunks)packages/tasks/src/balances.ts
(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/client/src/getBalances.ts
[error] 360-360: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🔇 Additional comments (1)
packages/tasks/src/balances.ts (1)
115-115
: Output formatting enhancement approved
The formatting changes improve the readability of the address outputs and provide clear separation between different address types.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation