Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SPL token balances #204

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: SPL token balances #204

wants to merge 3 commits into from

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Dec 13, 2024

  • Fixed a bug where Solana SPL tokens where treated as ERC-20
  • Added querying SPL token balances

Summary by CodeRabbit

  • New Features

    • Enhanced support for SPL tokens alongside ERC20 tokens in balance fetching.
    • Introduced a new task for fetching balances with improved parameters for various blockchain addresses.
  • Bug Fixes

    • Improved error handling and output formatting for wallet address issues, providing clearer instructions for users.
  • Documentation

    • Updated error messages to guide users on setting up environment variables for different blockchain private keys.

@fadeev fadeev requested review from andresaiello and a team as code owners December 13, 2024 13:01
Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request enhance the getBalances function to support both ERC20 and SPL tokens, introducing logic to differentiate between EVM and SVM virtual machines. The function now includes improved error handling for multicall failures and adds a mechanism to fetch SPL token balances from the Solana blockchain. Additionally, modifications in the balances.ts file improve error messaging and output formatting, refining the user experience when querying balances.

Changes

File Path Change Summary
packages/client/src/getBalances.ts Updated getBalances function to support SPL tokens, improved error handling for multicalls, and expanded balance retrieval logic.
packages/tasks/src/balances.ts Enhanced error handling and output formatting in the main function, added balancesTask for improved user instructions.

Possibly related issues

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fadeev fadeev changed the title fix solana balance query feat: SPL token balances Dec 13, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
packages/client/src/getBalances.ts (1)

360-360: Simplify conditional check using optional chaining

The condition if (r.result && r.result.value && r.result.value.length > 0) can be simplified using optional chaining for better readability.

Suggested code change:

- if (r.result && r.result.value && r.result.value.length > 0) {
+ if (r.result?.value?.length > 0) {
🧰 Tools
🪛 Biome (1.9.4)

[error] 360-360: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e088f9 and 20f1876.

📒 Files selected for processing (2)
  • packages/client/src/getBalances.ts (2 hunks)
  • packages/tasks/src/balances.ts (1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/client/src/getBalances.ts

[error] 360-360: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

🔇 Additional comments (1)
packages/tasks/src/balances.ts (1)

115-115: Output formatting enhancement approved

The formatting changes improve the readability of the address outputs and provide clear separation between different address types.

packages/client/src/getBalances.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant