-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use docker healthcheck for localnet e2e #2353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes
I'm having a hard time telling if e2e is just generally unstable or if this change is causing more instability |
10e5db1
to
b4eda96
Compare
1861866
to
3e7855d
Compare
fa2f875
to
d6afe15
Compare
d6afe15
to
cd4a5f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2353 +/- ##
===========================================
- Coverage 68.72% 68.72% -0.01%
===========================================
Files 302 302
Lines 19168 19169 +1
===========================================
Hits 13174 13174
- Misses 5347 5348 +1
Partials 647 647
|
229ae0d
to
bd061d0
Compare
LGTM |
Description
Use a docker health check rather than sleeping in e2e to wait for e2e start. Also reduce keygen height.
The keygen height parameters are very sensitive, the following combinations seem to result in random test failures:
I have selected parameters which appear to be stable, but I will need a few CI runs to know for sure.
Reduced CI time by 30-60 seconds, but is mostly to make local development faster.
Update: need to accelerate preparams generation a bit. Also cache it on a docker volume to avoid pointless recomputation when running locally.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: