Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use docker healthcheck for localnet e2e #2353

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jun 19, 2024

Description

Use a docker health check rather than sleeping in e2e to wait for e2e start. Also reduce keygen height.

The keygen height parameters are very sensitive, the following combinations seem to result in random test failures:

  • 20 25
  • 20 30
  • 25 30

I have selected parameters which appear to be stable, but I will need a few CI runs to know for sure.

Reduced CI time by 30-60 seconds, but is mostly to make local development faster.

Update: need to accelerate preparams generation a bit. Also cache it on a docker volume to avoid pointless recomputation when running locally.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@gartnera gartnera added the no-changelog Skip changelog CI check label Jun 19, 2024
@gartnera gartnera marked this pull request as ready for review June 19, 2024 19:20
@gartnera gartnera requested a review from a team June 19, 2024 19:27
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@gartnera
Copy link
Member Author

LGTM if CI passes

I'm having a hard time telling if e2e is just generally unstable or if this change is causing more instability

@gartnera gartnera marked this pull request as draft June 19, 2024 23:20
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jun 19, 2024
@gartnera gartnera force-pushed the localnet-healthcheck branch from 10e5db1 to b4eda96 Compare June 19, 2024 23:53
@gartnera gartnera force-pushed the localnet-healthcheck branch from 1861866 to 3e7855d Compare June 20, 2024 00:27
@github-actions github-actions bot added ci Changes to CI pipeline or github actions and removed ci Changes to CI pipeline or github actions labels Jun 20, 2024
@gartnera gartnera force-pushed the localnet-healthcheck branch from fa2f875 to d6afe15 Compare June 20, 2024 01:53
@github-actions github-actions bot removed the ci Changes to CI pipeline or github actions label Jun 20, 2024
@gartnera gartnera force-pushed the localnet-healthcheck branch from d6afe15 to cd4a5f0 Compare June 20, 2024 02:02
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (5e3c3ba) to head (bb9309d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2353      +/-   ##
===========================================
- Coverage    68.72%   68.72%   -0.01%     
===========================================
  Files          302      302              
  Lines        19168    19169       +1     
===========================================
  Hits         13174    13174              
- Misses        5347     5348       +1     
  Partials       647      647              
Files Coverage Δ
zetaclient/config/config.go 0.00% <0.00%> (ø)

@gartnera gartnera force-pushed the localnet-healthcheck branch from 229ae0d to bd061d0 Compare June 20, 2024 02:42
@gartnera gartnera marked this pull request as ready for review June 20, 2024 02:59
@gartnera gartnera mentioned this pull request Jun 20, 2024
10 tasks
@julianrubino
Copy link
Member

LGTM

@gartnera gartnera merged commit 2bb6f7b into develop Jun 20, 2024
25 of 27 checks passed
@gartnera gartnera deleted the localnet-healthcheck branch June 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants