Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add stateful end to end test #2360

Merged
merged 9 commits into from
Jun 21, 2024
Merged

test: add stateful end to end test #2360

merged 9 commits into from
Jun 21, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Jun 20, 2024 •
edited
Loading

Description

Ports changes from v16

Closes: #2259

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title Import data tests v17 test: add statefull end to end test Jun 20, 2024
gartnera
gartnera reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@gartnera gartnera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict slightly with #2353. We will need to tune the healthcheck parameters for this scenario.

contrib/localnet/docker-compose-import-data.yml Outdated Show resolved Hide resolved
contrib/localnet/docker-compose-import-data.yml Outdated Show resolved Hide resolved
contrib/localnet/scripts/start-zetacored.sh Outdated Show resolved Hide resolved
@kingpinXD kingpinXD requested a review from gartnera June 20, 2024 18:11
@kingpinXD kingpinXD marked this pull request as ready for review June 20, 2024 18:11
@kingpinXD kingpinXD requested a review from gartnera June 20, 2024 21:34
@kingpinXD kingpinXD changed the title test: add statefull end to end test test: add stateful end to end test Jun 20, 2024
gartnera
gartnera approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@gartnera gartnera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I don't think this is valuable but it does look ok

contrib/localnet/docker-compose-import-data.yml Show resolved Hide resolved
@kingpinXD kingpinXD merged commit f95f0e9 into develop Jun 21, 2024
19 checks passed
@kingpinXD kingpinXD deleted the import-data-tests-v17 branch June 21, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@gartnera gartnera gartnera approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

@skosito skosito Awaiting requested review from skosito

@swift1337 swift1337 Awaiting requested review from swift1337

Assignees
No one assigned
Labels
breaking:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command to run e2e test on imported data from mainnet (Port from v16)
3 participants
@kingpinXD @gartnera @lumtis