Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TODOs in rpc unit tests #2329

Merged
merged 12 commits into from
Jun 19, 2024
Merged

test: fix TODOs in rpc unit tests #2329

merged 12 commits into from
Jun 19, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Jun 7, 2024

Description

Fix TODOs in ethermint rpc unit tests.

Closes: #2302

Type of change

Unit tests fixes.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.54%. Comparing base (c667168) to head (2c39d46).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2329      +/-   ##
===========================================
+ Coverage    68.37%   68.54%   +0.17%     
===========================================
  Files          302      302              
  Lines        19178    19178              
===========================================
+ Hits         13112    13145      +33     
+ Misses        5426     5383      -43     
- Partials       640      650      +10     
Files Coverage Δ
rpc/backend/call_tx.go 60.26% <ø> (ø)

... and 4 files with indirect coverage changes

@skosito skosito changed the title Rpc tests todo test: fix TODOs in rpc unit tests Jun 7, 2024
@skosito skosito marked this pull request as ready for review June 7, 2024 16:15
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skosito skosito requested a review from swift1337 as a code owner June 19, 2024 17:26
@skosito skosito merged commit a292450 into develop Jun 19, 2024
19 checks passed
@skosito skosito deleted the rpc-tests-todo branch June 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TODOs in rpc/backend unit tests
3 participants