-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: created btc dust amount constant and renaming #2327
Conversation
…ithdrawalDustAmount
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2327 +/- ##
========================================
Coverage 68.06% 68.06%
========================================
Files 299 299
Lines 18971 18971
========================================
Hits 12913 12913
Misses 5421 5421
Partials 637 637
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem the change modify any logic in ZetaClient did we forget to do
2000+BTCWithdrawalDustAmount
?
Does this fix #2326? |
Description
The temporary hotfix for dust btc amount is in zetaclient. The fix needs to be done in zetacore to prevent dust CCTX from registration (#2326). The PR only ported the constant and remaining.
BtcDustOffset
->BtcNonceMarkOffset
and createdBTCWithdrawalDustAmount
constant for zetacore usage.Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: