refactor: inbound and outbound vote processing

[kingpinXD]

Description

• Refactor VoteOnObservedInboundTx, to break it down into smaller functions.
• Refactor VoteOnObservedOutboundTx, to break it down into smaller functions
• Add unit tests to improve coverage
• Remove cli tests for crosschian module .
• Add a validate function for cctx
• Modify the code base to use only InboundParams.Cointype everywhere.

Closes: #1800
#1180
#1801
#1802

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Checklist:

• I have added unit tests that prove my fix feature works

[github-actions]

!!!WARNING!!!
nosec detected in the following files: x/crosschain/types/outbound_params_test.go, x/crosschain/keeper/msg_server_vote_inbound_tx.go, x/crosschain/keeper/msg_server_vote_outbound_tx.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

[codecov]

Codecov Report

Attention: Patch coverage is 91.72260% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 54.00%. Comparing base (1e0d859) to head (a89f2ba).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1853      +/-   ##
===========================================
+ Coverage    52.01%   54.00%   +1.99%     
===========================================
  Files          235      241       +6     
  Lines        13382    13535     +153     
===========================================
+ Hits          6960     7309     +349     
+ Misses        5987     5779     -208     
- Partials       435      447      +12     

Files	Coverage Δ
x/crosschain/keeper/cctx.go	86.27% <100.00%> (-3.84%)	⬇️
x/crosschain/keeper/events.go	83.33% <100.00%> (+26.66%)	⬆️
x/crosschain/keeper/gas_payment.go	80.64% <100.00%> (+1.07%)	⬆️
.../crosschain/keeper/msg_server_migrate_tss_funds.go	72.35% <ø> (ø)
x/crosschain/keeper/msg_server_whitelist_erc20.go	82.14% <ø> (ø)
x/crosschain/migrations/v4/migrate.go	92.00% <100.00%> (ø)
x/crosschain/types/authz.go	100.00% <100.00%> (ø)
x/crosschain/types/inbound_params.go	100.00% <100.00%> (ø)
x/crosschain/types/message_abort_stuck_cctx.go	100.00% <100.00%> (ø)
x/crosschain/types/message_refund_aborted.go	100.00% <100.00%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

[skosito]

just some minor comments

[lumtis]

@kingpinXD I think the PR title is misleading, we're refactoring the inbound/outbound processing logic, not the voting logic although this logic is part of the vote messages

[lumtis]

Answered some of the comments in discussions