You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a preliminary task in preparation of #1800 and #1801, this can also be directly implemented in one of the PR above.
We have currently directly manipulate with the CCTX object in the voteInbound/voteOutbound logic when adding for example adding new outbound parameter for regular outbound or revert. We should break down the general state transition of CCTX in small low level method that can be easily tested and reused.
These methods should be ideally stateless, only interacting with the CCTX object passed as argument, for reliable testing (in the types package)
We should remove the CreateNewCCTX currently in the keeper package
The logic can also be simplified in evm-hook.go when creating new CCTX upon observed events on ZetaChain.
Right now we call we create an artificial MsgVoteOnObservedInboundTx message by calling NewMsgVoteOnObservedInboundTx to initialize the inbound, which is very dirty and confusing.
The text was updated successfully, but these errors were encountered:
This is a preliminary task in preparation of #1800 and #1801, this can also be directly implemented in one of the PR above.
We have currently directly manipulate with the CCTX object in the voteInbound/voteOutbound logic when adding for example adding new outbound parameter for regular outbound or revert. We should break down the general state transition of CCTX in small low level method that can be easily tested and reused.
These methods should be ideally stateless, only interacting with the CCTX object passed as argument, for reliable testing (in the
types
package)We should remove the
CreateNewCCTX
currently in thekeeper
packageExample of methods:
The logic can also be simplified in
evm-hook.go
when creating new CCTX upon observed events on ZetaChain.Right now we call we create an artificial
MsgVoteOnObservedInboundTx
message by callingNewMsgVoteOnObservedInboundTx
to initialize the inbound, which is very dirty and confusing.The text was updated successfully, but these errors were encountered: