Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the --ledger --hd-path hint for clarity #1553

Merged
merged 4 commits into from
Jan 11, 2024
Merged

docs: Update the --ledger --hd-path hint for clarity #1553

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
511776d
Update the --ledger --hd-path hint for clarity
CryptoFewka Jan 10, 2024
313457b
Update changelog.md
CryptoFewka Jan 10, 2024
afc6811
Merge branch 'develop' into ledger-hd-path-hint
CharlieMc0 Jan 11, 2024
da1c808
Update cmd/zetacored/main.go
CryptoFewka Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
* Remove chain id from the index for observer mapper and rename it to observer set.
* Add logger to smoke tests
* [1521](https://github.com/zeta-chain/node/pull/1521) - replace go-tss lib version with one that reverts back to thorchain tss-lib
* Update --ledger flag hint

### Chores
* [1446](https://github.com/zeta-chain/node/pull/1446) - renamed file `zetaclientd/aux.go` to `zetaclientd/utils.go` to avoid complaints from go package resolver.
Expand Down
2 changes: 1 addition & 1 deletion cmd/zetacored/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
if strings.Contains(err.Error(), "cannot set custom bip32 path with ledger") {
printNotice([]string{
"note: --ledger flag can't be used with Ethereum HD path (used by default)",
"use --hd-path=\"\" in the command to use Cosmos HD path",
"Please set a blank path with --hd-path="" to use Cosmos HD path instead.",

Check failure on line 37 in cmd/zetacored/main.go

View workflow job for this annotation

GitHub Actions / gosec 

syntax error: unexpected literal " to use Cosmos HD path instead." in composite literal; possibly missing comma or }

Check failure on line 37 in cmd/zetacored/main.go

View workflow job for this annotation

GitHub Actions / smoke-test 

syntax error: unexpected literal " to use Cosmos HD path instead." in composite literal; possibly missing comma or }

Check failure on line 37 in cmd/zetacored/main.go

View workflow job for this annotation

GitHub Actions / gosec-cosmos 

syntax error: unexpected literal " to use Cosmos HD path instead." in composite literal; possibly missing comma or }

Check failure on line 37 in cmd/zetacored/main.go

View workflow job for this annotation

GitHub Actions / build-and-test 

syntax error: unexpected literal " to use Cosmos HD path instead." in composite literal; possibly missing comma or }

Check failure on line 37 in cmd/zetacored/main.go

View workflow job for this annotation

GitHub Actions / build-and-test 

syntax error: unexpected literal " to use Cosmos HD path instead." in composite literal; possibly missing comma or }
CryptoFewka marked this conversation as resolved.
Show resolved Hide resolved
})
os.Exit(1)
}
Expand All @@ -42,7 +42,7 @@

func printNotice(messages []string) {
if len(messages) == 0 {
return

Check failure on line 45 in cmd/zetacored/main.go

View workflow job for this annotation

GitHub Actions / lint 

expected operand, found 'return' (typecheck)
}
border := strings.Repeat("*", len(messages[0])+4) // 4 to account for padding
fmt.Println(border)
Expand Down
Loading