Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the --ledger --hd-path hint for clarity #1553

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

CryptoFewka
Copy link
Contributor

@CryptoFewka CryptoFewka commented Jan 10, 2024

Description

I was attempting to set up my wallet on a ledger, and ran in to a wall. I misinterpreted the error message that was returned, and thought that text explicitly saying "do X to achieve Y" would be more clear.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

- replace the second line of the hint with `Please set a blank path with --hd-path="" to use Cosmos HD path instead.`
@CryptoFewka CryptoFewka changed the title Update the --ledger --hd-path hint for clarity Refactor: Update the --ledger --hd-path hint for clarity Jan 10, 2024
@CryptoFewka CryptoFewka changed the title Refactor: Update the --ledger --hd-path hint for clarity WIP: Update the --ledger --hd-path hint for clarity Jan 10, 2024
@CryptoFewka CryptoFewka changed the title WIP: Update the --ledger --hd-path hint for clarity docs: Update the --ledger --hd-path hint for clarity Jan 10, 2024
cmd/zetacored/main.go Outdated Show resolved Hide resolved
@lumtis lumtis merged commit bd88cf0 into develop Jan 11, 2024
15 checks passed
@lumtis lumtis deleted the ledger-hd-path-hint branch January 11, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants