Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): improve stateful e2e testing #1538

Merged
merged 18 commits into from
Jan 10, 2024
Merged

test(e2e): improve stateful e2e testing #1538

merged 18 commits into from
Jan 10, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jan 8, 2024

Description

  • Make stateful e2e testing directly with one Makefile command without manual interaction
  • Replace zetavisor with cosmovisor for the test

To perform the upgrade test, run:

make stateful-upgrade-source
cd contrib/localnet
docker-compose logs orchestrator -f

This start the chain with v11, send a upgrade proposal to current source at 200, run smoke tests, rerun smoke tests after upgrade and client restart.

For V11, a specific branch v11.0.0-patch-core-params is used to patch the hardcoded deployed contract addresses on local goerli since these values have changed after smoke tests revamp.

We will have to update the script each time to test with the next version for upgrade.

Note: seems there is an issue with the core params refactoring: e6ccc5be11ab9a18ea4a9f68519f89bc5bd21212
The upgrade test passes before this PR

Copy link

github-actions bot commented Jan 8, 2024

!!!WARNING!!!
nosec detected in the following files: contrib/localnet/orchestrator/smoketest/config/config.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Jan 8, 2024
@lumtis lumtis changed the title refactor(e2e): improve stateful e2e testing test(e2e): improve stateful e2e testing Jan 9, 2024
@lumtis lumtis marked this pull request as ready for review January 9, 2024 22:37
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@lumtis lumtis merged commit 3283191 into develop Jan 10, 2024
15 checks passed
@lumtis lumtis deleted the stateful-e2e branch January 10, 2024 20:46
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants