Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GetTssAddress related code in crosschain #1547

Closed
lumtis opened this issue Jan 9, 2024 · 0 comments · Fixed by #1948
Closed

Remove deprecated GetTssAddress related code in crosschain #1547

lumtis opened this issue Jan 9, 2024 · 0 comments · Fixed by #1948
Assignees
Milestone

Comments

@lumtis
Copy link
Member

lumtis commented Jan 9, 2024

For upgrade testing: #1538
In order to run the E2E tests on V11 and test upgrade V11 -> V12. GetTssAddress moved to observer module has been reimplemented in the crosschain module to maintain compatibility with the generated client.

  // GetTssAddress queries the tss address of the module.
  // Deprecated: Moved to observer
  // TODO: remove after v12 once upgrade testing is no longer needed with v11
  rpc GetTssAddress(QueryGetTssAddressRequest) returns (QueryGetTssAddressResponse) {
    option (google.api.http).get = "/zeta-chain/crosschain/get_tss_address";
  }

Once V12 is completed, upgrade testing v11 -> v12 will no longer be necessary and compatibility will no longer be necessary. The code above should be removed.

To list the code to be removed the following line can be searched in the code

// https://github.com/zeta-chain/node/issues/1547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant