feat: allow setting liquidity cap for ZRC20 #1205
Conversation
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
lumtis
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
ws4charlie
as code owners
| if txOrigin == "" { | ||
| txOrigin = msg.Sender | ||
| } | ||
| if len(logs) > 0 { |
There was a problem hiding this comment.
Does len(logs) == 0 mean something wrong (e.g., we always expect some logs)? Just curious about what pre-assumption we had in our mind.
There was a problem hiding this comment.
It prevents doing unnecessary call to fetch system contracts since there would be no logs to iterate
| } | ||
|
|
||
| // update the liquidity cap | ||
| coin.LiquidityCap = msg.LiquidityCap |
There was a problem hiding this comment.
My understanding is that when currentTotalSupply already > msg.LiquidityCap, the ZRC20 will be capped immediately, correct?
There was a problem hiding this comment.
currentSupply + amount > liquidityCap is the condition checked, therefore setting a liquidity cap below current supply would immediately blocks the deposits
Description
Allow setting a liquidity cap for a
ZRC20. The value is stored in theForeignCoinobject. If the liquidity cap is reached (total minted on ZetaChain + inbound amount > liquidity cap) the cctx is automatically reverted to limit the liquidity on ZetaChain.The value can be set from admin group 2 through the
MsgUpdateZRC20LiquidityCapmessage.Add smoke tests for the change
Other changes:
HandleEvmDeposittestsZRC20DepositAndCallContracttestsCloses: #1187
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: