Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete tests for DepositZRC20AndCallContract in deposits.go #1206

Closed
lumtis opened this issue Sep 27, 2023 · 0 comments
Closed

Complete tests for DepositZRC20AndCallContract in deposits.go #1206

lumtis opened this issue Sep 27, 2023 · 0 comments
Labels
m:fungible test Tests related

Comments

@lumtis
Copy link
Member

lumtis commented Sep 27, 2023

The PR #1205 adds test cases for the ZRC20DepositAndCallContract function.

However, we need to add a test case called DepositZRC20AndCallContract with a sample smart contract to check the function correctly reverts with the wrong data.

It is a bigger scope than the above smart contract since we need to add a sample smart contract for testing purposes.
@lumtis lumtis added m:fungible test Tests related labels Sep 27, 2023
@lumtis lumtis closed this as completed Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
m:fungible test Tests related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lumtis