Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat 406 from Microsoft as 429 #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ngoral
Copy link

@ngoral ngoral commented Feb 15, 2022

According to documentation Microsoft servers don't send 429, but sometimes they start sending 406, which basically means "try again later" as I see it.
I'd rather receive TooManyRequests error instead of NotAcceptable, 'cause it requires the same processing.
As far as I'm concerned, other services do not send 406, so it should be OK.

@ngoral ngoral marked this pull request as ready for review February 15, 2022 15:34
@aglushkov
Copy link

@zaru can you please merge and release new version? This 406 error is really annoying for many people

@collimarco
Copy link
Contributor

This proposal is semantically wrong: you cannot catch a 406, which has a very specific meaning, and raise TooManyRequests . It may produce exceptions that are extremely confusing and hard to debug in the future, with other push services, or with future changes.

However I understand that the bug is caused by Microsoft. Is there at least a specific resp.message that we can detect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants