Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Push Notification service (WNS) returns the wrong status code for rate limiting #3501

Open
collimarco opened this issue Jan 13, 2023 · 1 comment
Open

Windows Push Notification service (WNS) returns the wrong status code for rate limiting #3501

collimarco opened this issue Jan 13, 2023 · 1 comment
Labels
area-Notifications Toast notification, badges, Live Tiles, push notifications bug Something isn't working

Comments

@collimarco
Copy link

Describe the bug

From your docs:

406 Not Acceptable
The cloud service exceeded its throttle limit.
Please send your request after the Retry-After header value in the response

This is plain wrong and against the standard. You MUST return 429 Too Many Requests for rate limiting.

Returning 406 breaks various web push libraries and services, that don't handle the response properly.

For example: zaru/webpush#103

Steps to reproduce the bug

Send many web push messages in parallel to Edge / WNS.

Expected behavior

Return HTTP status 429 for rate limiting.

Screenshots

No response

NuGet package version

None

Windows version

No response

Additional context

No response
@collimarco collimarco added the bug Something isn't working label Jan 13, 2023
@ghost ghost added the needs-triage label Jan 13, 2023
@gabbybilka gabbybilka transferred this issue from microsoft/microsoft-ui-xaml Mar 13, 2023
@gabbybilka gabbybilka added area-Notifications Toast notification, badges, Live Tiles, push notifications and removed needs-triage labels Mar 13, 2023
@collimarco collimarco mentioned this issue Dec 10, 2024
Open
@collimarco
Copy link
Author

Any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Notifications Toast notification, badges, Live Tiles, push notifications bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@collimarco @gabbybilka