-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test concat of dimension coordinate not backed by an index #44
Conversation
The simplest test that shows this issue is described in pydata/xarray#8871 EDIT: And a proposed fix is pydata/xarray#8872 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 87.66% 88.12% +0.46%
==========================================
Files 13 13
Lines 851 893 +42
==========================================
+ Hits 746 787 +41
- Misses 105 106 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR now uses a branch on my fork of xarray, which contains the (unmerged upstream) PRs pydata/xarray#8711, pydata/xarray#8714 and pydata/xarray#8872. All three of these are needed to get the new test in this PR to pass. |
I'm going to merge this, making this package depend on my branch of xarray. Once those changes are merged upstream I can unpin it from that specific branch, see #14 (comment). |
Adds a test showing a problem in xarray - if I build two datasets that have dimension coordinates which are explicitly not backed by an index (which is possible by passing the new
xr.Coordinates
object explicitly to the constructor), then upon concatenating these, xarray sees the dimension coordinate and attempts to automatically rebuild a new index (which will fail in my case). I need to be able to turn off that behaviour somehow.