-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required changes in xarray to avoid creating indexes #14
Comments
The above isn't quite true. We should distinguish here between
|
EDIT: Raised pydata/xarray#8871 on xarray to track it. |
I made a branch on my fork of xarray, which contains the (unmerged upstream) PRs pydata/xarray#8711, pydata/xarray#8714 and pydata/xarray#8872. All three of these are needed for (1), i.e. to be able to create virtual datasets not backed by any indexes, and concatenate them without attempting to create any indexes. Once those three changes are merged upstream and released I'll be able to close this issue (though #35 will still be unsolved.) |
Actually now the only unmerged PR to xarray that is needed for (1) is pydata/xarray#8872, so I've changed the VirtualiZarr build to only point to that in 08774f7. |
Is this now closable? 👀 |
Yes I think so! But note that additional changes in xarray would be required to support #18 . |
Everything mentioned in this issue pydata/xarray#8699 also needs to be done for this library to work.EDIT: This is a lie, see comment below
The text was updated successfully, but these errors were encountered: