Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds defaults in open_virtual_dataset_from_v3_store #234

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Adds defaults in open_virtual_dataset_from_v3_store #234

merged 3 commits into from
Aug 28, 2024

Conversation

norlandrhagen
Copy link
Collaborator

@norlandrhagen norlandrhagen commented Aug 28, 2024 •
edited
Loading

Tiny PR that adds None as defaults to drop_variables and indexes in open_virtual_dataset_from_v3_store. These defaults mirror open_virtual_dataset.
Might add a bit of QOL for behavior like: TypeError: open_virtual_dataset_from_v3_store() missing 1 required positional argument: 'drop_variables'

  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst

@TomNicholas TomNicholas merged commit 18c5a10 into main Aug 28, 2024
8 checks passed
@TomNicholas TomNicholas deleted the open_vds_zarr_v3_defaults branch August 28, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norlandrhagen @TomNicholas