Skip to content

Commit

Permalink
Adds defaults in open_virtual_dataset_from_v3_store (#234)
Browse files Browse the repository at this point in the history
* adds defaults

* update releases.rst

* default empty list instead of None
  • Loading branch information
norlandrhagen authored Aug 28, 2024
1 parent 4f9647c commit 18c5a10
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions docs/releases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ v1.0.1 (unreleased)

New Features
~~~~~~~~~~~~
- Adds defaults for `open_virtual_dataset_from_v3_store` in (:pull:`234`)
By `Raphael Hagen <https://github.com/norlandrhagen>`_.

- New ``group`` option on ``open_virtual_dataset`` enables extracting specific HDF Groups.
(:pull:`165`) By `Scott Henderson <https://github.com/scottyhq>`_.

Expand Down
4 changes: 2 additions & 2 deletions virtualizarr/readers/zarr.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

def open_virtual_dataset_from_v3_store(
storepath: str,
drop_variables: list[str],
indexes: Mapping[str, Index] | None,
drop_variables: list[str] = [],
indexes: Mapping[str, Index] | None = None,
) -> Dataset:
"""
Read a Zarr v3 store and return an xarray Dataset containing virtualized arrays.
Expand Down

0 comments on commit 18c5a10

Please sign in to comment.