Publishing reviewable attributes enhancements #24
Conversation
jakubjezek001
added
sponsored
|
It is a littble bit weird that the checkbox hides the enum, and the same enum hides the checkbox. Only one of them should do it... It should either always show checkbox, and in that case selection of review track is mandatory (without |
Co-authored-by: Jakub Trllo <[email protected]>
Update EnumDef label from "reviewTrack" to "reviewableTrack". WIP on (no branch): Update EnumDef label for reviewableTrack.
…ttribute names, default values, and logic for reviewable sources.
Remove redundant reviewable flag distribution logic and update handling of review-related data in plugin files.
- Refactored logic for setting reviewable source visibility based on changes.
- Simplified logic for setting visibility of reviewable source based on review value.
Changed the comparison operator from "is not" to "!=" for checking if the review source is different from the default.
Adjusted tooltip description for selecting source of reviewable files.
|
Is this the intended result? if yes, tell me to approve. |
yes please, shane the label size of the hidden attribute is alwais breaking the look. @iLLiCiTiT is there perhaps a way to define the size of column even by hidden attributes so it is not jumpy? |
In this case maybe just 'disabling' instead of hiding could be sufficient? |
|
I vote for disabling it instead of changing visibility. Because I don't know how to do it with label... |
There was a problem hiding this comment.
Tested locally and confirmed it works with the UI update.
I agree with previous reviewers that making the toggle disable the track selection instead of hiding it would be better imo.
Also very picky, but for UI/UX consistency, should we replicate the same UI between create attributes and instance attributes selection ? Currently we have 1 combo list with < none > entry in the creator then 1 checkbox + 1 combolist in the instance UI.
| @@ -192,23 +224,36 @@ def get_instance_attr_defs(self): | |||
| ) | |||
| ] | |||
| if self.product_type == "plate": | |||
| instance_attributes.extend([ | |||
There was a problem hiding this comment.
Just to be sure, this means we do not want to let the user edit vSyncOn and vSyncTrack on the instance anymore ?
I think I still do not get how exactly those 2 features are connected. The way I understood it was:
reviewableSource+review: control if a review h264 product gets created through OIIO and FFmpeg along the plate and from which sourcevSyncOn+vSyncTrack: define the hero track (main track) to construct a vertical synchronization.. not exactly sure what come after that
There was a problem hiding this comment.
Yes this is quite confusing I agree:
vSync attributes does not need to be user editable on instances. Those changes were not propagated anywhere and also this would be quite difficult to prapagate them in first place. It is much more easy if user will recreate those instances from scratch.
Reviewable flaging is now doing following. Review attribute is saying if the plate needs to have acompanied reviwable representation and reviableSource is only saying what should be used for the representation creation.
There was a problem hiding this comment.
Also very picky, but for UI/UX consistency, should we replicate the same UI between create attributes and instance attributes selection ? Currently we have 1 combo list with < none > entry in the creator then 1 checkbox + 1 combolist in the instance UI.
This is intentional. It would not make sense to have acctive review attribute with reviewableSource set to '< none >`.
In the PublishClip class, implemented a check to maintain backward compatibility for the "reviewableSource" tag metadata by handling the "reviewTrack" key appropriately when present in the data.
… value. Refactor tooltip formatting.
Changelog Description
Instance attributes for reviewable items with interactivity involve two key elements for proper distribution: setting either a reviewable track or simply flagging for later extraction by transcoding tools. Either of the option will interact with the other.
Additional info
closes #21
Testing notes:
<none>. You'll see a new attribute for the review switch.