Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata keys and add colorspace data #23

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 6, 2024

Changelog description

  • Colorspace data to instances and versionData.
  • Remove redundant function set_prev_item from create_otio_timeline.
  • Fix key naming for colorspace in ExtractClipEffects plugin.

Testing steps

  • open your testing project in Hiero
  • publish clips and notice that log details from Collect OTIO Subset Resources plugin is having at new representations data key colorspaceData with correct colorspace key with value the same as it is set at your hiero clip colorspace attribute.

dependencies

This PR has to be tested with ayon-core PR ynput/ayon-core#996
This also ideally needs to be tested with #24 becuse without it there will be integrate.py issue with two reviewable representations for one instance - this will only happen if ExtractorOIIOTranscode plugin will have set presets for Hiero host.

 to instances and versionData. Remove redundant function set_prev_item from create_otio_timeline. Fix key naming for colorspace in ExtractClipEffects plugin.
@jakubjezek001 jakubjezek001 linked an issue Nov 6, 2024 that may be closed by this pull request
@jakubjezek001 jakubjezek001 self-assigned this Nov 6, 2024
@jakubjezek001 jakubjezek001 added sponsored This is directly sponsored by a client or community member type: bug Something isn't working labels Nov 6, 2024
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks valid, cannot test.

Changed the core addon version requirement from >0.3.2 to >1.0.7 for compatibility with other addons.
@jakubjezek001 jakubjezek001 merged commit 613f69f into develop Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-7105_colorspaceData not correctly distributed from clips
3 participants