Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Fix Creator tool #1018

Merged
merged 4 commits into from
Nov 21, 2024
+1 −1
Merged

Tools: Fix Creator tool #1018

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
582dce4
Fix typo
kalisp Nov 21, 2024
5ccdfc2
Fix plugins returning empty list
kalisp Nov 21, 2024
0c57779
Revert "Fix plugins returning empty list"
kalisp Nov 21, 2024
962df74
Better RegularExpressionValidatorClass.Invalid used
kalisp Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/ayon_core/tools/creator/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def __init__(self):

def validate(self, text, pos):
results = super(ProductNameValidator, self).validate(text, pos)
if results[0] == self.Invalid:
if results[0] == self.invalid:
kalisp marked this conversation as resolved.
Show resolved Hide resolved
self.invalid.emit(self.invalid_chars(text))
return results

Expand Down
4 changes: 4 additions & 0 deletions client/ayon_core/tools/pyblish_pype/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,8 @@ def restore_checkstates(self):

def update_with_result(self, result):
instance = result["instance"]
if isinstance(instance, list):
Copy link
Member

@iLLiCiTiT iLLiCiTiT Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a minut, Context and Instance are both list. Why you need to do this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted fix, it may cause havoc.
I'll try switch Harmony to Publisher UI instead.

instance = instance.pop() if instance else None
if instance is None:
instance_id = self.controller.context.id
else:
Expand Down Expand Up @@ -976,6 +978,8 @@ def prepare_records(self, result, suspend_logs):
prepared_records = []
instance_name = None
instance = result["instance"]
if isinstance(instance, list):
instance = instance.pop() if instance else None
if instance is not None:
instance_name = instance.data["name"]

Expand Down
Loading