Tools: Fix Creator tool #1018
Merged
Tools: Fix Creator tool #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
reviewed
Nov 21, 2024
iLLiCiTiT
reviewed
Nov 21, 2024
| @@ -780,6 +780,8 @@ def restore_checkstates(self): | |||
|
|
|||
| def update_with_result(self, result): | |||
| instance = result["instance"] | |||
| if isinstance(instance, list): | |||
There was a problem hiding this comment.
Wait a minut, Context and Instance are both list. Why you need to do this?
There was a problem hiding this comment.
Reverted fix, it may cause havoc.
I'll try switch Harmony to Publisher UI instead.
iLLiCiTiT
changed the title
iLLiCiTiT
approved these changes
Nov 21, 2024
iLLiCiTiT
changed the title
|
Might be good to include in the PR description that this is a PySide6 related fix, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This affects DCC with old Pyblish which will be hopefully soon obsolete.
Additional info
Found during testing Harmony.