-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for o1 models #19
Conversation
Added support for OpenAI o1-mini and o1-preview models by mapping them to the `o200k_base` encoding. This update ensures compatibility with the latest tiktoken changes as introduced in version 0.8.0 of the official library. Fixes compatibility issues with models not yet included in tiktoken-php.
This proposal is based on the recent update in tiktoken (see: openai/tiktoken@0.7.0...0.8.0#diff-088caf12b3c3144a63ff973b98bc3eec7e53f4c1d75d11d49720cbcd2744fd30R72), where these models were added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add support for chatgpt-4o-
prefix as well.
…' => 'value'). Co-authored-by: Deni <[email protected]>
I saw that they added it however I do not get what is |
Models For example: (repl)> str_start_with('chatgpt-4o-latest', 'gpt-4o-')
(repl)> false |
Sure, I was curious about the nature of both. Here is what I found
|
@yethee Could you kindly review and approve this pull request, as it covers the core changes for o1 model support? I will handle the addition of the chatgpt-4o-* models in a separate pull request to maintain clarity and ensure a structured update process. Thanks |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Thanks! |
Another difference between them is the update lifecycle.
|
Added support for OpenAI o1-mini and o1-preview models by mapping them to the
o200k_base
encoding. This update ensures compatibility with the latest tiktoken changes as introduced in version 0.8.0 of the official library.Fixes compatibility issues with models not yet included in tiktoken-php.