Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing o1 models support #18

Closed
SeriousOne opened this issue Oct 1, 2024 · 4 comments
Closed

Missing o1 models support #18

SeriousOne opened this issue Oct 1, 2024 · 4 comments

Comments

@SeriousOne
Copy link

Are there plans to support o1 models: o1-preview and o1-mini? I suppose they use already existing encodings, so it is not a problem to add support for them.

@yethee
Copy link
Owner

yethee commented Oct 1, 2024

Can you confirm that these models use the encoding o200k_base?

@SeriousOne
Copy link
Author

Unfortunately, I haven't found any confirmation. When I asked ChatGPT and Perplexity, they both answered that this is cl100k_base. Sure, that's not reliable. I think it's better to wait until it is known for sure.

@iamarsenibragimov
Copy link
Contributor

I've proposed support for the o1-mini and o1-preview models by mapping the "o1-" prefix to the "o200k_base" encoding in pull request #19.

This proposal is based on the recent update in tiktoken (see: openai/tiktoken@0.7.0...0.8.0#diff-088caf12b3c3144a63ff973b98bc3eec7e53f4c1d75d11d49720cbcd2744fd30R72), where these models were added.

@yethee
Copy link
Owner

yethee commented Oct 12, 2024

Fixed in #19

@yethee yethee closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants