add TypifiedElement.exists and HtmlElement.exists #91
Conversation
| public boolean exists() { | ||
| try { | ||
| getWrappedElement().isDisplayed(); | ||
| return true; |
There was a problem hiding this comment.
You should do return true at the end of the method.
There was a problem hiding this comment.
To have return at the method end instead of the middle. It's more a code style issue, rather then something that doesn't work. Also on code coverage report it should look better.
|
What's the reason behind this changes? |
| import org.openqa.selenium.Dimension; | ||
| import org.openqa.selenium.Point; | ||
| import org.openqa.selenium.WebElement; | ||
| import org.openqa.selenium.*; |
There was a problem hiding this comment.
pls configure your IDEA to never use wildcard imports
I remember using |
|
So, provide the reason in description, fix the rest wildcard imports, then squash commits into one and we will merge it then. |
|
@artkoshelev can i merge this? |
add TypifiedElement.exists and HtmlElement.exists
I remember using exists().matches(element) several times.
I saw PR #83 and thought that I'm not the only one who needs this functionality.