Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default method to check if element displayed to always return … #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update default method to check if element displayed to always return … #83

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc5816c
update default method to check if element displayed to always return …
michaelsuzukisagi May 23, 2015
d485782
#83,Updated default method to check if element displayed to always re…
michaelsuzukisagi May 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion htmlelements-java/src/main/java/ru/yandex/qatools/htmlelements/element/TypifiedElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,15 @@ public String toString() {
* @return Whether or not the element is displayed
*/
public boolean isDisplayed() {
return getWrappedElement().isDisplayed();
try{
return getWrappedElement().isDisplayed();
} catch (Exception e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL Either log or rethrow this exception. rule

//ignore and return false to indicate element is not visible.
}
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you're presuming that if element isn't found (this is when exception is thrown), then it's invisible. But this is hiding that fact (that element wasn't found) from the developer who runs the tests and therefore I think it's not the right way to handle this.

Instead you should be catching that exception in place where you call isDisplayed method.

}


/**
* Is the element currently enabled or not? This will generally return true for everything but
* disabled input elements.
Expand Down