core: Walk regions for rewritings instead of ops #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the pattern rewriter walker walks an operation, and tries to apply patterns on all contained operations, including itself. This is not what we would want, as rewriting a toplevel operation is dangerous, if that operation does not have a parent. This commit changes the walker to walk regions instead of operations, so it is clear that the toplevel operation will not be modified. This is similar to what MLIR currently does in applyPatternsAndFoldGreedily.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3506 +/- ##
==========================================
- Coverage 90.33% 90.33% -0.01%
==========================================
Files 464 464
Lines 58157 58152 -5
Branches 5557 5558 +1
==========================================
- Hits 52536 52530 -6
Misses 4190 4190
- Partials 1431 1432 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
superlopuh
approved these changes
Nov 22, 2024
alexarice
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pattern rewriter walker walks an operation, and tries to apply patterns on all contained operations, including itself. This is not what we would want, as rewriting a toplevel operation is dangerous, if that operation does not have a parent.
This commit changes the walker to walk regions instead of operations, so it is clear that the toplevel operation will not be modified. This is similar to what MLIR currently does in applyPatternsAndFoldGreedily.