Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Walk regions for rewritings instead of ops #3506

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Commits on Nov 22, 2024

  1. core: Walk regions for rewritings instead of ops

    Currently, the pattern rewriter walker walks an operation, and tries to
    apply patterns on all contained operations, including itself.
    This is not what we would want, as rewriting a toplevel operation is
    dangerous, if that operation does not have a parent.
    
    This commit changes the walker to walk regions instead of operations, so
    it is clear that the toplevel operation will not be modified. This is
    similar to what MLIR currently does in applyPatternsAndFoldGreedily.
    math-fehr committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    39a2e0a View commit details
    Browse the repository at this point in the history
  2. Fix mlir-based test

    math-fehr committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    58e4f1f View commit details
    Browse the repository at this point in the history
  3. Address comments

    math-fehr committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b9e6b3a View commit details
    Browse the repository at this point in the history
  4. Fix bug

    math-fehr committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4471675 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    e593460 View commit details
    Browse the repository at this point in the history