core: make TypedAttribute not generic #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It feels like a logical split, and leaves space for some upcoming shared dialects helpers.
Co-authored-by: Sasha Lopoukhine <[email protected]>
I'm working towards removing the stream dialect, and would like to simplify it as much as possible before copying to both memref_stream and snitch_stream. I don't think the constr overload is pulling its weight, it's much simpler just to provide a shorthand for the BaseAttr constraint, and only return a ParamAttrConstraint from constr.
…3486) Another incremental change towards getting rid of the stream dialect, now that the definitions are small enough it feels like the right move is to duplicate the definitions, as there's no particular reason for them to be coupled.
Bumps [marimo](https://github.com/marimo-team/marimo) from 0.9.20 to 0.9.21. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/marimo-team/marimo/releases">marimo's releases</a>.</em></p> <blockquote> <h2>0.9.21</h2> <h2>What's Changed</h2> <ul> <li>docs: Add <code>frameworks</code> in README list; fix typo by <a href="https://github.com/Haleshot"><code>@Haleshot</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2879">marimo-team/marimo#2879</a></li> <li>improvement: if mimebundle only contains markdown/latex, convert to html by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2881">marimo-team/marimo#2881</a></li> <li>improvement: make it clearer/possible to convert to SQL and markdown by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2878">marimo-team/marimo#2878</a></li> <li>fix: remove upper bound on websockets by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2892">marimo-team/marimo#2892</a></li> <li>docs: update deploying docs by <a href="https://github.com/akshayka"><code>@akshayka</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2894">marimo-team/marimo#2894</a></li> <li>style: fix banner overflow by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2895">marimo-team/marimo#2895</a></li> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>@pre-commit-ci</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2896">marimo-team/marimo#2896</a></li> <li>feat: <em>display</em> protocol by <a href="https://github.com/akshayka"><code>@akshayka</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2471">marimo-team/marimo#2471</a></li> <li>upgrade plotly.js to support maplibre by <a href="https://github.com/Light2Dark"><code>@Light2Dark</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2903">marimo-team/marimo#2903</a></li> <li>improvement: mpl proxy middleware by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2875">marimo-team/marimo#2875</a></li> <li>example: leafmap by <a href="https://github.com/akshayka"><code>@akshayka</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2912">marimo-team/marimo#2912</a></li> <li>fix: only show data-types if coming from a dataframe by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2907">marimo-team/marimo#2907</a></li> <li>improvement: proxy lsp through main server by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2911">marimo-team/marimo#2911</a></li> <li>fix: correct flush of anywidget messages by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2620">marimo-team/marimo#2620</a></li> <li>force wrap columns in data-table when needed by <a href="https://github.com/Light2Dark"><code>@Light2Dark</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2917">marimo-team/marimo#2917</a></li> <li>fix: route catch all by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2915">marimo-team/marimo#2915</a></li> <li>example: improve dagger example by <a href="https://github.com/mscolnick"><code>@mscolnick</code></a> in <a href="https://redirect.github.com/marimo-team/marimo/pull/2920">marimo-team/marimo#2920</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/marimo-team/marimo/compare/0.9.20...0.9.21">https://github.com/marimo-team/marimo/compare/0.9.20...0.9.21</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/marimo-team/marimo/commit/401b2d68679ca0ec37237bfc2f5bdcb8e8d460b0"><code>401b2d6</code></a> release: 0.9.21</li> <li><a href="https://github.com/marimo-team/marimo/commit/8d63f3a99567247218278764e88442ba5d32f454"><code>8d63f3a</code></a> example: improve dagger example (<a href="https://redirect.github.com/marimo-team/marimo/issues/2920">#2920</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/4684421c817c514978ebc0a9af55fe4fa2e84a65"><code>4684421</code></a> fix: route catch all (<a href="https://redirect.github.com/marimo-team/marimo/issues/2915">#2915</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/62e9915bb31fc348685e8b5c190e5f94d3fd7faa"><code>62e9915</code></a> force wrap columns in data-table when needed (<a href="https://redirect.github.com/marimo-team/marimo/issues/2917">#2917</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/a02d8e1d0954bce35aeb4c89ab989353461f1480"><code>a02d8e1</code></a> fix: correct flush of anywidget messages (<a href="https://redirect.github.com/marimo-team/marimo/issues/2620">#2620</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/e87ecb38baa5ee9826ec3358f09782029d915e78"><code>e87ecb3</code></a> improvement: proxy lsp through main server (<a href="https://redirect.github.com/marimo-team/marimo/issues/2911">#2911</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/f6f7ac5bc755cbbca6b1d024fc4ee6780cf7c0dd"><code>f6f7ac5</code></a> fix: only show data-types if coming from a dataframe (<a href="https://redirect.github.com/marimo-team/marimo/issues/2907">#2907</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/f697a7b03aca066e514140d8ccc665e1b0886f2e"><code>f697a7b</code></a> example: leafmap (<a href="https://redirect.github.com/marimo-team/marimo/issues/2912">#2912</a>)</li> <li><a href="https://github.com/marimo-team/marimo/commit/9ec5952202c164badc5107c206431c03a5cce846"><code>9ec5952</code></a> chore: dedupe pnpm lockfile</li> <li><a href="https://github.com/marimo-team/marimo/commit/78358ea7309428a6b0cb557e99524ff2476d09d0"><code>78358ea</code></a> improvement: mpl proxy middleware (<a href="https://redirect.github.com/marimo-team/marimo/issues/2875">#2875</a>)</li> <li>Additional commits viewable in <a href="https://github.com/marimo-team/marimo/compare/0.9.20...0.9.21">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
A wrapper class to encapsulate the inference context. I have a feeling that we might want to split out the inference context into range and non-range variable assignments, this will hide the change from the signature of the `infer` method.
Refactors the assembly format directives to: - Remove some unnecessary classes that made the system rigid - Separate directives that go in a `type` clause from format directives
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alexarice/typed-attribute-generic #3505 +/- ##
=====================================================================
+ Coverage 90.32% 90.34% +0.01%
=====================================================================
Files 464 464
Lines 58052 58037 -15
Branches 5560 5549 -11
=====================================================================
- Hits 52437 52434 -3
+ Misses 4187 4177 -10
+ Partials 1428 1426 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
alexarice
merged commit e0224a8
into
alexarice/typed-attribute-generic
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bit that used the generic wasn't type-sound anyway.
Stacked PR + need to rebase past making float a typed attribute